-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support RBAC by default with kube-dns addon #2637
Support RBAC by default with kube-dns addon #2637
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jstangroome Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
/assign @dlorenc |
@minikube-bot ok to test |
@jstangroome Builds failed?) |
I've built minikube locally on a Ubuntu 18.04 machine with Golang 1.10 and run I cannot grok the reason for failure from the logs of the test runs linked in this PR discussion. I'm happy to dig further if anyone can provide some direction. cc @Jokero |
I think this is obsolete with the kubeadm bootstrapper. |
A step toward #1722
Kubernetes already pre-defines a ClusterRoleBinding
system:kube-dns
which gives thekube-dns
ServiceAccount the required rules to operate in a cluster with RBAC enabled, i.e.: